Repository navigation
Send the pyiceberg User-Agent on S3 remote signing requests - #4367
Merged
Merged
Conversation
S3V4RestSigner posts to the REST catalog's signing endpoint from its own requests session, so those calls went out as python-requests/<version> instead of the pyiceberg User-Agent that the catalog sends. Share the value through a small _user_agent() helper and set it on signer requests the same way the catalog session does, after the header properties. Co-authored-by: Isaac <no-reply@databricks.com>
Contributor
Author
|
A note on the last line of the description: Isaac is the internal agent harness I use at work, and Claude is the model. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
S3V4RestSignersends its signing requests to the REST catalog's signer endpoint from its ownrequests.Session(), without a User-Agent. Those calls show up aspython-requests/<version>instead of thepyiceberg/<version> (<python implementation> <python version>)value that the catalog sends since #4330, following the REST spec's User-Agent recommendation (apache/iceberg#17727).This moves the value into a small
_user_agent()helper inpyiceberg.catalog.restand sets it on signer requests the same way the catalog session does, after theheader.*properties.Are these changes tested?
Yes.
test_s3v4_rest_signernow checks that the signing request carries the pyiceberg User-Agent. Without this change it fails, because the request sendspython-requests/<version>.Are there any user-facing changes?
S3 remote signing requests now send the pyiceberg User-Agent. As on the catalog session, a
header.User-Agentproperty does not override it.This pull request and its description were written by Isaac.